Device tree modification

Hello,

We designed a carrier board with a Colibri Module, and we are currently doing the new device tree of the board.

We are new in this, and I have a small question.
We used the SODIMM Pin n°86, EIM_ADDR25 of SoC as a GPIO. So i configure it as a GPIO in the file imx6dl.dtsi:

MX6QDL_PAD_EIM_A25__GPIO5_IO02		PAD_CTRL_HYS_PU

But in another section, this pin is already declared:

	/* pins used on module */
imx6dl-colibri {
[...]
	pinctrl_spi_cs1: spi_cs1 {
		fsl,pins = <
			MX6QDL_PAD_EIM_A25__GPIO5_IO02		PAD_CTRL_NO	/* SPI cs */
		>;
	};

Do I need to comment these lines?

Regards,
Pierre-Olivier

Rather than comment it out, I’d recommend disabling the node which uses the pin (ecspi4). This can be done in the dts file (imx6dl-colibri-eval-v3.dts):

&ecspi4 {

	......

	/* status = "okay"; */
	status = "disabled";
};

Alternatively, if you must use the SPI interface, leave it enabled, and configure a different pin for the chip select (in the code below, pinctrl_spi_cs_alt must be another pinctrl binding which you define with an alternate chip select pin for the interface).

&ecspi4 {

	.....
	/* Override: pinctrl-0 = <&pinctrl_ecspi4 &pinctrl_spi_cs1>; */
	pinctrl-0 = <&pinctrl_ecspi4 &pinctrl_spi_cs_alt>;
	.....

	status = "okay";
};

Thanks for your help, I already defined a new CS pin, so it’s fine.